Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency defenseunicorns/uds-cli to v0.19.0 #250

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 19, 2024

This PR contains the following updates:

Package Update Change
defenseunicorns/uds-cli minor 0.17.0 -> 0.19.0
defenseunicorns/uds-cli minor v0.17.0 -> v0.19.0
defenseunicorns/uds-cli minor v0.16.0 -> v0.19.0

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

defenseunicorns/uds-cli (defenseunicorns/uds-cli)

v0.19.0

Compare Source

What's Changed

NOTE:


New Contributors

Full Changelog: defenseunicorns/uds-cli@v0.18.0...v0.19.0

v0.18.0

Compare Source

What's Changed

New Contributors

Full Changelog: defenseunicorns/uds-cli@nightly-unstable...v0.18.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team November 19, 2024 19:45
@renovate renovate bot force-pushed the renovate/defenseunicorns-uds-cli-0.x branch from b0011a0 to e37825e Compare November 19, 2024 20:55
MxNxPx
MxNxPx previously approved these changes Nov 19, 2024
Copy link
Contributor

@MxNxPx MxNxPx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm on this version locally, but would defer to @JoeHCQ1 and @jacobbmay

@JoeHCQ1
Copy link
Contributor

JoeHCQ1 commented Nov 20, 2024

@MxNxPx , this one is a bit more tricky. We're only promising to work with a particular version of the UDS CLI, the same one which is in the build image we're using to run the UDS commands in the UDS Tasks file.

Reason for it: @jacobbmay would have to weigh in here for the specifics. I recall him saying we had problems arise earlier on that resulted from mismatched UDS CLI version so we're using the build image to specify the agree-able UDS CLI version.

Problems it causes:

  1. I cannot run any tasks we use the docker image for, because I'm on an ARM processor and we don't publish an ARM version of that build image. If we dropped this and dropped the build image from CI, that friction would be gone.
  2. It suggest to others that the system is brittle.
  3. It obfuscates the actual command. Parsing these kinds of docker commands is 5-10x more complicated than just reading the straight command. This isn't going to help the customer who wants to understand what's happening in UDS.

@jacobbmay
Copy link
Collaborator

The reason for using a build-harness image wasn't because of uds-cli issues. It was other OS dependencies that some after deploy scripts use that didn't have same options available in a customer environment's CI image which caused failures.

The purpose of the image is to provide a consistent deployment environment and eliminate "works on my machine" scenarios between us and customer environments. It eliminates needing to make assumptions about a deployment environment since we can tell users to just use that image for a guaranteed working deployment container.

Regarding the commands being a bit more complicated to look at, the tasks are set up so we can spin up the container locally. In a real deployment the image would just be selected as the runner image and UDS commands would be configured in the job scripts. No need to build something that works like our deploy tasks.

renovate bot and others added 2 commits November 20, 2024 15:03
| datasource  | package                 | from    | to      |
| ----------- | ----------------------- | ------- | ------- |
| github-tags | defenseunicorns/uds-cli | 0.17.0  | 0.19.0  |
| github-tags | defenseunicorns/uds-cli | v0.17.0 | v0.19.0 |
| github-tags | defenseunicorns/uds-cli | v0.16.0 | v0.19.0 |
@JoeHCQ1 JoeHCQ1 force-pushed the renovate/defenseunicorns-uds-cli-0.x branch from 178dc33 to dced2b8 Compare November 20, 2024 20:03
Copy link
Contributor Author

renovate bot commented Nov 20, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@JoeHCQ1
Copy link
Contributor

JoeHCQ1 commented Nov 20, 2024

Updated to the latest build harness because it has UDS CLI 0.19.0 https://github.com/defenseunicorns/build-harness/blob/2.0.46/.tool-versions#L34

@JoeHCQ1 JoeHCQ1 merged commit 6fbbc24 into main Nov 20, 2024
1 check passed
@JoeHCQ1 JoeHCQ1 deleted the renovate/defenseunicorns-uds-cli-0.x branch November 20, 2024 20:09
This was referenced Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants