Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove eks-d & eks-a #231

Merged
merged 7 commits into from
Oct 24, 2024
Merged

feat: remove eks-d & eks-a #231

merged 7 commits into from
Oct 24, 2024

Conversation

MxNxPx
Copy link
Contributor

@MxNxPx MxNxPx commented Oct 22, 2024

Removing all code that supported building and publishing EKS-D related bundles.

@MxNxPx MxNxPx requested a review from a team as a code owner October 22, 2024 19:31
tasks.yaml Show resolved Hide resolved
tasks/create.yaml Outdated Show resolved Hide resolved
tasks.yaml Show resolved Hide resolved
Copy link
Contributor

@JoeHCQ1 JoeHCQ1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a few changes are in order to embrace RKE2 beyond removing EKSD.

Also, we should redeploy the clusters first.

@MxNxPx
Copy link
Contributor Author

MxNxPx commented Oct 23, 2024

I think a few changes are in order to embrace RKE2 beyond removing EKSD.

Also, we should redeploy the clusters first.

hi @JoeHCQ1 - i could see that point of view, but i wonder if at some point it may make sense to split the mono-bundle into multiple bundles. if so, then some of the naming and folder structure would make that easier. totally could be wrong about that though, and could just flatten things if that makes more sense.

i'm OK with holding off on merging this until we replace the EKS-D clusters with RKE2.

@JoeHCQ1
Copy link
Contributor

JoeHCQ1 commented Oct 23, 2024

wonder if at some point it may make sense to split the mono-bundle into multiple bundles. if so, then some of the naming and folder structure would make that easier.

@MxNxPx I'm good with keeping it this way then. I would love to hear sometime what the potential benefits of multiple bundles may be in our context.

@JoeHCQ1 JoeHCQ1 merged commit 7ab7ec8 into main Oct 24, 2024
1 check passed
@JoeHCQ1 JoeHCQ1 deleted the remove-eksd branch October 24, 2024 15:56
@JoeHCQ1
Copy link
Contributor

JoeHCQ1 commented Oct 24, 2024

Oh dang it - I forgot we were waiting until we'd redeployed the clusters. Well, that needed done anyway.

This was referenced Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants