Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update bundle to be compatible with eks-management cluster #198

Merged
merged 8 commits into from
Sep 26, 2024

Conversation

jacobbmay
Copy link
Collaborator

eks-management cluster already has a packages resource so packages being deployed into a management cluster to be used for a permanent eks-d registry mirror were updated to watch for packages.uds.dev instead of just packages to avoid this conflict.

Also includes some task updates to support deploying a partial bundle so it is possible to reuse the full bundle to deploy only the dependencies needed to run Nexus for the permanent registry mirror.

tasks.yaml Outdated
@@ -43,6 +44,14 @@ tasks:
with:
config-dir: ./scratch/configs/test

- name: deploy-mgmt
description: Deploy bundle to mgmt cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you flesh out the description so I know why I'd deploy the bundle to the mgmt cluster? Is this a prior step to the final deploy or is it the deploy?

Maybe a few paragraphs of docs would clear it up better.

Copy link
Contributor

@JoeHCQ1 JoeHCQ1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick so I'm not withholding the approval:

the task name deploy-published-mgmt would autofill better if deploy-mgmt-published. Now it feels more like a variant of the task.

@jacobbmay jacobbmay merged commit 8fedecc into main Sep 26, 2024
@jacobbmay jacobbmay deleted the eks-anywhere-registry-bundle branch September 26, 2024 18:56
This was referenced Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants