-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update bundle to be compatible with eks-management cluster #198
Conversation
tasks.yaml
Outdated
@@ -43,6 +44,14 @@ tasks: | |||
with: | |||
config-dir: ./scratch/configs/test | |||
|
|||
- name: deploy-mgmt | |||
description: Deploy bundle to mgmt cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you flesh out the description so I know why I'd deploy the bundle to the mgmt cluster? Is this a prior step to the final deploy or is it the deploy?
Maybe a few paragraphs of docs would clear it up better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick so I'm not withholding the approval:
the task name deploy-published-mgmt
would autofill better if deploy-mgmt-published
. Now it feels more like a variant of the task.
eks-management cluster already has a
packages
resource so packages being deployed into a management cluster to be used for a permanent eks-d registry mirror were updated to watch forpackages.uds.dev
instead of justpackages
to avoid this conflict.Also includes some task updates to support deploying a partial bundle so it is possible to reuse the full bundle to deploy only the dependencies needed to run Nexus for the permanent registry mirror.