Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gitlab update with SAML sso #117

Merged
merged 10 commits into from
May 29, 2024
Merged

feat: gitlab update with SAML sso #117

merged 10 commits into from
May 29, 2024

Conversation

blancharda
Copy link
Contributor

Tested and working (as well as we can with no actual custom CA) in dev.

KNOWN ISSUES:

  • The swap from OIDC -> SAML caused some unexpected failures for upgrades. You can either do a fresh install OR we can walk through manually adding a couple of client scopes in the keycloak admin portal (see slack thread for details)
  • The migrations job in our dev env is failing, as if the rails secret has been changed. I don't believe it HAS been changed, but we haven't been able to isolate if this is specific to our dev env, or a broader issue with the package upgrade

Given the workarounds, I recommend we push forward with the known issues to try and test on-prem in parallel.

@blancharda blancharda merged commit e7fea10 into main May 29, 2024
@blancharda blancharda deleted the feature/gl-update branch May 29, 2024 23:28
This was referenced Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants