Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove calls to process.exit for src/lib/assets/index.ts: #1796

Open
cmwylie19 opened this issue Feb 10, 2025 · 0 comments
Open

remove calls to process.exit for src/lib/assets/index.ts: #1796

cmwylie19 opened this issue Feb 10, 2025 · 0 comments

Comments

@cmwylie19
Copy link
Contributor

cmwylie19 commented Feb 10, 2025

Describe what should be investigated or refactored

There are several spots where Pepr calls process.exit(). This complicates the ability to do global logging, auditing, or cleanup. We should avoid this pattern to handle failure cases in a more graceful manner. Consider this explanation for why it's a bad idea.

We'll know we're done with this issue when each of those calls to process.exit() handle shutdown in a more graceful manner (e.g., throwing exceptions, passing control to some other function, etc.)

src/lib/assets/index.ts:      process.exit(1);
@cmwylie19 cmwylie19 added this to the v0.45.1 milestone Feb 10, 2025
@cmwylie19 cmwylie19 moved this from 🆕 New to 📋 Backlog in Pepr Project Board Feb 10, 2025
@cmwylie19 cmwylie19 removed this from the v0.45.1 milestone Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant