Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or rename apiToken from webhooks #1785

Open
samayer12 opened this issue Feb 7, 2025 · 1 comment · May be fixed by #1830
Open

Remove or rename apiToken from webhooks #1785

samayer12 opened this issue Feb 7, 2025 · 1 comment · May be fixed by #1830
Labels
enhancement New feature or request
Milestone

Comments

@samayer12
Copy link
Contributor

samayer12 commented Feb 7, 2025

Is your feature request related to a problem? Please describe.

A community question asked if apiToken is something that needs to be sanitized from the helm chart that is produced after running pepr build.

This might be a case of a lingering feature that causes confusion for users of Pepr. We could consider renaming it to reflect the non-sensitive nature of the apiToken field or removing it altogether. First, we'll have to research why it might have been introduced into the project.

@samayer12 samayer12 added the enhancement New feature or request label Feb 7, 2025
@cmwylie19
Copy link
Contributor

I like the idea of renaming it better. I think the intent is to have a unique path for the kube-apiserver to send the AdmissionReview objects

@cmwylie19 cmwylie19 added this to the v0.45.1 milestone Feb 9, 2025
@cmwylie19 cmwylie19 moved this from 🆕 New to 📋 Backlog in Pepr Project Board Feb 9, 2025
@cmwylie19 cmwylie19 linked a pull request Feb 13, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

2 participants