You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe what should be investigated or refactored
Many test assertions in src/lib/filter.test.ts use '.*' as part of the assertion condition. This is due to variable test output, which makes writing the test more complicated. We want confidence that log messages contain relevant information, so we should update the assertion matchers from '.*' to something more specific to the test-case instead of a permissive pattern that could even allow empty-string to pass.
Links to any relevant code
Examine src/lib/filter.test.ts.
Additional context
Find matches in the code base with grep -R "'\.\*'" src/**/*.test.ts
src/lib/filter/filter.test.ts: /Ignoring Admission Callback: Binding defines name regex '.*' but Object carries '.*'./,
src/lib/filter/filter.test.ts: /Ignoring Admission Callback: Binding defines name regex '.*' but Object carries '.*'./,
src/lib/filter/filter.test.ts: /Ignoring Admission Callback: Binding defines namespace regexes '.*' but Object carries '.*'./,
src/lib/filter/filter.test.ts: /Ignoring Admission Callback: Binding defines namespace regexes '.*' but Object carries '.*'./,
src/lib/filter/filter.test.ts: /Ignoring Admission Callback: Binding defines name '.*' but Object carries '.*'./,
src/lib/filter/filter.test.ts: /Ignoring Admission Callback: Binding defines kind '.*' but Request declares '.*'./,
src/lib/filter/filter.test.ts: /Ignoring Admission Callback: Binding defines group '.*' but Request declares '.*'./,
src/lib/filter/filter.test.ts: /Ignoring Admission Callback: Binding defines version '.*' but Request declares '.*'./,
src/lib/filter/filter.test.ts: /Ignoring Admission Callback: Object carries namespace '.*' but namespaces allowed by Capability are '.*'./,
src/lib/filter/filter.test.ts: /Ignoring Admission Callback: Binding defines namespaces '.*' but Object carries '.*'./,
src/lib/filter/filter.test.ts: /Ignoring Admission Callback: Binding defines labels '.*' but Object carries '.*'./,
src/lib/filter/filter.test.ts: /Ignoring Admission Callback: Binding defines annotations '.*' but Object carries '.*'./,
The text was updated successfully, but these errors were encountered:
Describe what should be investigated or refactored
Many test assertions in
src/lib/filter.test.ts
use'.*'
as part of the assertion condition. This is due to variable test output, which makes writing the test more complicated. We want confidence that log messages contain relevant information, so we should update the assertion matchers from'.*'
to something more specific to the test-case instead of a permissive pattern that could even allow empty-string to pass.Links to any relevant code
Examine
src/lib/filter.test.ts
.Additional context
Find matches in the code base with
grep -R "'\.\*'" src/**/*.test.ts
The text was updated successfully, but these errors were encountered: