Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid use of .* regex matches in test conditions #1779

Open
samayer12 opened this issue Feb 7, 2025 · 0 comments
Open

Avoid use of .* regex matches in test conditions #1779

samayer12 opened this issue Feb 7, 2025 · 0 comments
Labels

Comments

@samayer12
Copy link
Contributor

Describe what should be investigated or refactored

Many test assertions in src/lib/filter.test.ts use '.*' as part of the assertion condition. This is due to variable test output, which makes writing the test more complicated. We want confidence that log messages contain relevant information, so we should update the assertion matchers from '.*' to something more specific to the test-case instead of a permissive pattern that could even allow empty-string to pass.

Links to any relevant code

Examine src/lib/filter.test.ts.

Additional context

Find matches in the code base with grep -R "'\.\*'" src/**/*.test.ts

src/lib/filter/filter.test.ts:      /Ignoring Admission Callback: Binding defines name regex '.*' but Object carries '.*'./,
src/lib/filter/filter.test.ts:      /Ignoring Admission Callback: Binding defines name regex '.*' but Object carries '.*'./,
src/lib/filter/filter.test.ts:      /Ignoring Admission Callback: Binding defines namespace regexes '.*' but Object carries '.*'./,
src/lib/filter/filter.test.ts:      /Ignoring Admission Callback: Binding defines namespace regexes '.*' but Object carries '.*'./,
src/lib/filter/filter.test.ts:      /Ignoring Admission Callback: Binding defines name '.*' but Object carries '.*'./,
src/lib/filter/filter.test.ts:      /Ignoring Admission Callback: Binding defines kind '.*' but Request declares '.*'./,
src/lib/filter/filter.test.ts:      /Ignoring Admission Callback: Binding defines group '.*' but Request declares '.*'./,
src/lib/filter/filter.test.ts:      /Ignoring Admission Callback: Binding defines version '.*' but Request declares '.*'./,
src/lib/filter/filter.test.ts:      /Ignoring Admission Callback: Object carries namespace '.*' but namespaces allowed by Capability are '.*'./,
src/lib/filter/filter.test.ts:      /Ignoring Admission Callback: Binding defines namespaces '.*' but Object carries '.*'./,
src/lib/filter/filter.test.ts:      /Ignoring Admission Callback: Binding defines labels '.*' but Object carries '.*'./,
src/lib/filter/filter.test.ts:      /Ignoring Admission Callback: Binding defines annotations '.*' but Object carries '.*'./,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant