Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert module exists in build.version.test.ts #1725

Closed
samayer12 opened this issue Jan 24, 2025 · 1 comment
Closed

Assert module exists in build.version.test.ts #1725

samayer12 opened this issue Jan 24, 2025 · 1 comment
Labels
Milestone

Comments

@samayer12
Copy link
Contributor

samayer12 commented Jan 24, 2025

Describe what should be investigated or refactored

Files in integration/build.*.test.ts must build a unique pepr module so that the tests can run in parallel in CI and provide a faster feedback loop. build.version.test.ts (see #1642) captures current behavior of a bug reported in #1724 which conflicts with the Pepr docs.

This chore will be resolved with we can assert:

expect(existsSync(`${testModule}/dist`)).toBe(true);

and get a passing test.

Links to any relevant code

N/A

Additional context

Discovered in #1661.

@samayer12
Copy link
Contributor Author

We intend to remove the npx pepr build --version flag as part of #1724. Closing this issue since the test will be removed when we deprecate the --version flag.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pepr Project Board Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants