Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): chat completion with files #951

Merged
merged 55 commits into from
Sep 4, 2024
Merged

feat(ui): chat completion with files #951

merged 55 commits into from
Sep 4, 2024

Conversation

andrewrisse
Copy link
Contributor

@andrewrisse andrewrisse commented Aug 26, 2024

Description

Feature enables uploading files for chat when not using an assistant from the chat page.
The files are converted to pdf if needed, then parsed for text. The text gets stored as it's own message with metadata that indicates the message should be hidden (on the UI).

Checklist before merging

https://www.loom.com/share/9e9a1cb87217454f9e0fd9db0436b9fe?sid=9ecb91a7-aa82-4d2f-8acc-20da2bfb61c2

Deployed on LF-04

@andrewrisse andrewrisse marked this pull request as ready for review August 28, 2024 19:01
@andrewrisse andrewrisse requested a review from a team as a code owner August 28, 2024 19:01
Copy link
Contributor

@gregclark-defenseunicorns gregclark-defenseunicorns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewrisse

Found one thing I wanted address. Seems like the submit button for the prompt message is still enabled when a file is uploading to the message and making a weird edge case.

Steps:

  • Upload a file to the message
  • Submit the message while the file is uploading
  • File in message thread will show as uploading permanently
  • The File will then upload to the message bar without having to upload it again.

It would be best to disable the submit message button while the file is uploading to avoid this scenario

Screen.Recording.2024-08-29.at.1.01.07.PM.mov

@andrewrisse
Copy link
Contributor Author

@andrewrisse

Found one thing I wanted address. Seems like the submit button for the prompt message is still enabled when a file is uploading to the message and making a weird edge case.

Steps:

  • Upload a file to the message
  • Submit the message while the file is uploading
  • File in message thread will show as uploading permanently
  • The File will then upload to the message bar without having to upload it again.

It would be best to disable the submit message button while the file is uploading to avoid this scenario

Screen.Recording.2024-08-29.at.1.01.07.PM.mov

fixed

@andrewrisse andrewrisse merged commit 020dc07 into main Sep 4, 2024
19 checks passed
@andrewrisse andrewrisse deleted the file-chat branch September 4, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants