Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(api): raise exception on CRUD base fails #748

Merged
merged 5 commits into from
Jul 12, 2024
Merged

chore(api): raise exception on CRUD base fails #748

merged 5 commits into from
Jul 12, 2024

Conversation

alekst23
Copy link
Contributor

@alekst23 alekst23 commented Jul 9, 2024 •
edited
Loading

CRUD operations will now raise exceptions instead of catching them and returning None.

  • Will return None for exceptions that are due to no results from db

Delete function will only return True/False.

@alekst23 alekst23 requested a review from a team as a code owner July 9, 2024 22:31
@alekst23 alekst23 linked an issue Jul 9, 2024 that may be closed by this pull request
(chore) Raise errors on CRUD base operation fails #747
Closed
@netlify Netlify
Copy link

netlify bot commented Jul 9, 2024 •
edited
Loading

✅ Deploy Preview for leapfrogai-docs canceled.

Name Link
🔨 Latest commit d895a44
🔍 Latest deploy log https://app.netlify.com/sites/leapfrogai-docs/deploys/669182aeeb7b6000081c7265

@alekst23 alekst23 requested review from gphorvath and jalling97 July 10, 2024 14:52
@gphorvath gphorvath changed the title Raise exception on CRUD base fails chore(api): raise exception on CRUD base fails Jul 10, 2024
YrrepNoj
YrrepNoj previously approved these changes Jul 11, 2024
View reviewed changes
@alekst23 alekst23 force-pushed the 747-crud-raise-error branch from d7c55fa to 2ae3a47 Compare July 11, 2024 21:35
YrrepNoj
YrrepNoj previously approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@YrrepNoj YrrepNoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (after conflict is resolved).

@alekst23 alekst23 force-pushed the 747-crud-raise-error branch from 2ae3a47 to 63c3208 Compare July 12, 2024 18:22
@alekst23 alekst23 force-pushed the 747-crud-raise-error branch from 63c3208 to d895a44 Compare July 12, 2024 19:23
@alekst23 alekst23 enabled auto-merge (squash) July 12, 2024 19:53
@alekst23 alekst23 merged commit 4d8ff03 into main Jul 12, 2024
11 checks passed
@alekst23 alekst23 deleted the 747-crud-raise-error branch July 12, 2024 20:21
@github-actions github-actions bot mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gphorvath gphorvath gphorvath approved these changes

@YrrepNoj YrrepNoj YrrepNoj left review comments

@jalling97 jalling97 Awaiting requested review from jalling97

Assignees

@alekst23 alekst23

Labels
None yet
Projects
None yet
Milestone
Current - RAG UX Enhancements | Model...
Development

Successfully merging this pull request may close these issues.

(chore) Raise errors on CRUD base operation fails
3 participants
@alekst23 @gphorvath @YrrepNoj