Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui) Users can select an annotation to view the passage that was used #669

Closed
gregclark-defenseunicorns opened this issue Jun 20, 2024 · 1 comment · Fixed by #908
Closed
Assignees
Labels
enhancement New feature or request

Comments

@gregclark-defenseunicorns
Copy link
Contributor

gregclark-defenseunicorns commented Jun 20, 2024

User Story

As a LFAI user
I want the reference passage in my chat thread
So that I can have all the context together

Acceptance Criteria

Given I submit a prompt that references a RAG file Design: Annotation Links
When I click on the the annotation link at the end of the response
Then a window opens below the link displaying the passage of the reference file Design: Reference Window
And I am able to scroll file within the window

When I click on an annotation link that is already
Then the reference window closes

NOTE Only one reference window can be open at one time. So if one is already open and another is click then the previous one closes and the new one opens.

When I click on the annotations throughout the response ([1], [2], [3], etc)
Then I am auto scrolled to the bottom of the response
And the link's reference windows opens automatically (Copy behavior as though the link was clicked)

When a reference window opens for a PDF file
Then I see 2 tertiary buttons (Download and Launch)

When a reference windows opens for a NON PDF file
Then I see 1 tertiary button (Download)

When I click the Download button in the reference window
Then the file is downloaded Design: Reference Downloaded

When I click the Launch button in the reference window
Then a new tab opens displaying the PDF Design: PDF Viewer

Additional context

Design Links:

Functionality Video:
https://github.com/user-attachments/assets/6b9454e6-cde3-4c6a-883e-b755e7a1f379

@andrewrisse
Copy link
Contributor

blocked by #766

@andrewrisse andrewrisse added the blocked 🛑 Something needs to happen before this issues is worked label Jul 11, 2024
@gregclark-defenseunicorns gregclark-defenseunicorns removed the needs-design Needs designer review prior to work label Jul 18, 2024
@andrewrisse andrewrisse removed the blocked 🛑 Something needs to happen before this issues is worked label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants