Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI name discrepancies #492

Closed
CollectiveUnicorn opened this issue May 9, 2024 · 0 comments · Fixed by #495
Closed

Fix UI name discrepancies #492

CollectiveUnicorn opened this issue May 9, 2024 · 0 comments · Fixed by #495
Labels
possible-bug 🐛 Something may not be working
Milestone

Comments

@CollectiveUnicorn
Copy link
Contributor

Steps to reproduce

  • Run make build-ui it will attempt to build the wrong package.
  • Look for references in the codebase to lfaiui and leapfrogai-ui there's lingering references to the latter and incomplete references to the former.

Expected result

Consistent references to either lfaiui or leapfrogai-ui so that package builds are successful and correct values are loaded.

Actual Result

There are mismatch references to both

Visual Proof (screenshots, videos, text, etc)

Screenshot 2024-05-09 at 2 21 54 PM
Screenshot 2024-05-09 at 2 22 05 PM
Screenshot 2024-05-09 at 2 22 24 PM
Screenshot 2024-05-09 at 2 22 46 PM

Severity/Priority

Medium - This causes builds to fail and leads to confusing situations where the wrong package is deployed to the cluster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
possible-bug 🐛 Something may not be working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant