chore: refactoring API and adding stubs for new OpenAI endpoints #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for leapfrogai-docs canceled.
|
gerred
requested changes
Apr 25, 2024
There was a problem hiding this comment.
One thing we should be consistent on is using Union[x,y] vs. x | y in type signatures. We had users pinned on Python 3.8 (maybe now less relevant with our direciton) before type syntax was built into Python. I'm fine with moving either direction, but this PR should unify on one or the other.
Other than that, lgtm.
CollectiveUnicorn
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds stubs for new assistants endpoint
Refactors API into separate routers for each route