fix: send and cancel btn tooltips #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for leapfrogai-docs canceled.
|
gerred
approved these changes
Apr 24, 2024
|
Recommend merging with base branch before merge, otherwise lgtm!! |
gerred
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carbon applies the iconDescription as a tooltip for buttons that use icons. This label is attached as an aria-label to the svg component within the button, not the actual button. We need a test id to get the buttons for tests, while also ensuring the tooltips are not undefined for the user. I didn't want to put an aria-label on the button as well as the svg, so this solution fixes the tooltips while also ensuring tests pass.