Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api, tests): refactor api tests to centralize file pathing #1165

Merged
merged 18 commits into from
Sep 30, 2024

Conversation

gphorvath
Copy link

@gphorvath gphorvath commented Sep 29, 2024

Description

Addresses a mounting issue with our python tests where we are reconstructing relative file paths and throwing various not found exceptions while reading test data.

BREAKING CHANGES

None

CHANGES

Moves all test data file pathing into one central test util and attempt to replace as many instances as possible

Related Issue

None

Checklist before merging

@gphorvath gphorvath requested a review from a team as a code owner September 29, 2024 19:41
Copy link

netlify bot commented Sep 29, 2024

Deploy Preview for leapfrogai-docs canceled.

Name Link
🔨 Latest commit f9e1383
🔍 Latest deploy log https://app.netlify.com/sites/leapfrogai-docs/deploys/66fab5c68791ce0008b2f4a8

@gphorvath gphorvath self-assigned this Sep 29, 2024
justinthelaw
justinthelaw previously approved these changes Sep 30, 2024
@jalling97
Copy link
Contributor

Not sure if this is the PR for this, but would you be able to add a section to tests/README.md covering the how/why of the conformance tests? Unless I'm missing something I don't think I see where this info lives.

tests/README.md Outdated Show resolved Hide resolved
@gphorvath gphorvath enabled auto-merge (squash) September 30, 2024 15:40
@gphorvath gphorvath merged commit e2ce0f4 into main Sep 30, 2024
26 checks passed
@gphorvath gphorvath deleted the refactor-api-test-data-path branch September 30, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants