Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seaborn colormaps #879

Closed
okartal opened this issue Sep 25, 2019 · 4 comments
Closed

Add seaborn colormaps #879

okartal opened this issue Sep 25, 2019 · 4 comments

Comments

@okartal
Copy link

okartal commented Sep 25, 2019

Is it possible for deeptools to provide the perceptually uniform colormaps that have been added to seaborn in v0.8.0 (July 2017)? See here:

Added four new colormaps, created using viscm for perceptual uniformity. The new colormaps include two sequential colormaps (“rocket” and “mako”) and two diverging colormaps (“icefire” and “vlag”). These colormaps are registered with matplotlib on seaborn import and the colormap objects can be accessed in the seaborn.cm namespace.

@dpryan79
Copy link
Collaborator

We use matplotlib for plotting, I don't think seaborn existed yet when deepTools was first created.

@okartal
Copy link
Author

okartal commented Sep 25, 2019

Yes, I am aware of that but I thought it is maybe straightforward to add something similar to the code at https://github.com/mwaskom/seaborn/blob/master/seaborn/cm.py in order to register the colormaps with matplotlib.

@dpryan79
Copy link
Collaborator

Ah, gotcha, I'll look into that. Thanks!

@dpryan79 dpryan79 mentioned this issue Dec 3, 2019
4 tasks
@dpryan79
Copy link
Collaborator

dpryan79 commented Dec 3, 2019

This is now implemented in the develop branch for the next release, thanks for the suggestion!

@dpryan79 dpryan79 closed this as completed Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants