Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable GPU support for Generator #610

Closed
lalitpagaria opened this issue Nov 20, 2020 · 3 comments
Closed

Enable GPU support for Generator #610

lalitpagaria opened this issue Nov 20, 2020 · 3 comments
Assignees
@sadakmed
Labels
good first issue Good for newcomers type:feature New feature or request

Comments

@lalitpagaria
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently Generator doesn't utilise GPU. Hence creating this as a placeholder task to enable GPU support for Generator.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
For more details refer #587 and #590
@lalitpagaria lalitpagaria added the type:feature New feature or request label Nov 20, 2020
@tholor tholor added the good first issue Good for newcomers label Nov 23, 2020
@sadakmed
Copy link
Contributor

sadakmed commented Dec 6, 2020 •
edited
Loading

I want to take this issue. However, since there's no GPU support shouldn't use_gpu be False by default.

@tholor
Copy link
Member

tholor commented Dec 7, 2020 •
edited
Loading

Glad to hear that you want to work on this @sadakmed !

We kept the default to True to be in line with the other classes in Haystack (e.g. FARMReader). However, we are currently raising an error if it's set to True and a GPU is available: https://github.com/deepset-ai/haystack/blob/master/haystack/generator/transformers.py#L112

Let me know if you need any help while working on this!

@sadakmed sadakmed mentioned this issue Dec 9, 2020
Merged
@lalitpagaria
Copy link
Contributor Author

Closed with #669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sadakmed sadakmed

Labels
good first issue Good for newcomers type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tholor @sadakmed @lalitpagaria