Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAI Embedders #5620

Closed
Tracked by #5312
anakin87 opened this issue Aug 25, 2023 · 1 comment
Closed
Tracked by #5312

OpenAI Embedders #5620

anakin87 opened this issue Aug 25, 2023 · 1 comment
Assignees
@anakin87
Labels
2.x Related to Haystack v2.0
Milestone
2.0-beta

Comments

@anakin87
Copy link
Member

anakin87 commented Aug 25, 2023 •
edited
Loading

According to the Embedders proposal,
we should start implementing 3 classes:

  • OpenAIEmbeddingBackend (not a component): for local models, this is needed to reuse instances and save memory. Let's see if it too makes sense in this case (remote inference)
  • OpenAITransformersTextEmbedder
  • OpenAITransformersDocumentEmbedder
@anakin87 anakin87 mentioned this issue Aug 25, 2023
Closed
@ZanSara ZanSara added the 2.x Related to Haystack v2.0 label Aug 28, 2023
@anakin87 anakin87 self-assigned this Sep 8, 2023
This was referenced Sep 13, 2023
Merged
Merged
@ZanSara ZanSara added this to the 2.0 blockers milestone Sep 25, 2023
@anakin87
Copy link
Member Author

Implemented in #5801 and #5822.
(OpenAIEmbeddingBackend is not needed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anakin87 anakin87

Labels
2.x Related to Haystack v2.0
Projects
None yet
Milestone
2.0-beta
Development

No branches or pull requests
2 participants
@ZanSara @anakin87