Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_code does not check whether components names are valid Python variable names #3855

Closed
ZanSara opened this issue Jan 12, 2023 · 0 comments
Closed
Labels
1.x P3 Low priority, leave it in the backlog topic:pipeline topic:security relevant to Haystack's threat model type:bug Something isn't working wontfix This will not be worked on

Comments

@ZanSara
Copy link
Contributor

ZanSara commented Jan 12, 2023

Describe the bug

Solution:
to_code should clean the compoent names before using them.

  • it could use unicodedata.category() to filter out control characters, for example.
  • It could also apply a strong regex on component names and replace anything that is not alphanumeric with an underscore.

@tstadel

@ZanSara ZanSara added type:bug Something isn't working topic:pipeline labels Jan 12, 2023
@ZanSara ZanSara added the topic:security relevant to Haystack's threat model label Jan 25, 2023
@masci masci added the P2 Medium priority, add to the next sprint if no P1 available label Feb 8, 2023
@julian-risch julian-risch added the Contributions wanted! Looking for external contributions label Mar 13, 2023
@masci masci removed the Contributions wanted! Looking for external contributions label Dec 13, 2023
@masci masci added P3 Low priority, leave it in the backlog 1.x and removed P2 Medium priority, add to the next sprint if no P1 available labels Jan 8, 2024
@masci masci added the wontfix This will not be worked on label Feb 23, 2024
@masci masci closed this as completed Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x P3 Low priority, leave it in the backlog topic:pipeline topic:security relevant to Haystack's threat model type:bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants