Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring feature parity to SQLDocumentStore #3523

Closed
masci opened this issue Nov 4, 2022 · 1 comment
Closed

Bring feature parity to SQLDocumentStore #3523

masci opened this issue Nov 4, 2022 · 1 comment
Labels
Contributions wanted! Looking for external contributions topic:document_store topic:sql wontfix This will not be worked on

Comments

@masci
Copy link
Contributor

masci commented Nov 4, 2022

Is your feature request related to a problem? Please describe.
The SQLDocumentStore was originally designed to support other vector databases storing additional data (e.g. metadata), still it implements the BaseDocumentStore interface and it is supposed to implement all the relative load/store/query capabilities.

Unfortunately the SQLDocumentStore behaves rather differently from the others, as proven by the inability to run some basic tests here

Describe the solution you'd like
The SQLDocumentStore successfully runs all the tests from DocumentStoreBaseTestAbstract

Describe alternatives you've considered
The SQLDocumentStore doesn't implement BaseDocumentStore anymore and is changed into an object specialised in providing metadata storing facilities to other Document Stores.

@ZanSara ZanSara added the Contributions wanted! Looking for external contributions label Jan 17, 2023
@masci masci added the wontfix This will not be worked on label Dec 6, 2023
@masci
Copy link
Contributor Author

masci commented Dec 6, 2023

Closing as won't fix

@masci masci closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributions wanted! Looking for external contributions topic:document_store topic:sql wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants