Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pipeline telemetry #3342

Closed
vblagoje opened this issue Oct 7, 2022 · 4 comments · Fixed by #3657
Closed

Improve pipeline telemetry #3342

vblagoje opened this issue Oct 7, 2022 · 4 comments · Fixed by #3657

Comments

@vblagoje
Copy link
Member

vblagoje commented Oct 7, 2022

Is your feature request related to a problem? Please describe.
There are a couple of minor issues related to current pipeline telemetry:

  • The pipeline event is currently named pipeline and it doesn't follow the Posthog naming convention of "[noun][verb]".
  • Not properly naming pipelines with multiple retrievers as they are now simply classified "Unknown pipeline"
  • Potentially change how we currently account for pipeline uniqueness (a.k.a identity, fingerprint)

Describe the solution you'd like
Given the above list of issues we should:

  • Rename the pipeline event Pipeline run
  • Properly classify all instances of "Unknown pipeline"
  • Rethink pipeline uniqueness (this one might remain the same)

Describe alternatives you've considered
No alternatives have been considered as these are minor issues that do not affect Haystack users.

Additional context
This feature is related to telemetry, it doesn't affect Haystack users.

@vblagoje vblagoje self-assigned this Oct 7, 2022
@vblagoje vblagoje modified the milestones: https://github.com/deepset-ai/haystack/milestone/10, 1.10.0 Oct 19, 2022
@masci masci removed this from the 1.10.0 milestone Oct 20, 2022
@vblagoje vblagoje reopened this Dec 2, 2022
@vblagoje
Copy link
Member Author

vblagoje commented Dec 2, 2022

Partially completed with #3657

@vblagoje
Copy link
Member Author

vblagoje commented Dec 2, 2022

What else should we do here @julian-risch ?

@julian-risch
Copy link
Member

@vblagoje Only "pipeline uniqueness" is left from the original issue. Let's create a new issue for that in https://github.com/deepset-ai/haystack-private and close the one here.

@vblagoje vblagoje closed this as completed Dec 2, 2022
@julian-risch
Copy link
Member

Closing because all topics except for pipeline uniqueness are resolved. We'll continue working on that offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants