Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-evaluate BasePipeline #2302

Closed
ZanSara opened this issue Mar 11, 2022 · 0 comments · Fixed by #2438
Closed

Re-evaluate BasePipeline #2302

ZanSara opened this issue Mar 11, 2022 · 0 comments · Fixed by #2438
Assignees
@ZanSara
Labels
topic:pipeline type:refactor Not necessarily visible to the users

Comments

@ZanSara
Copy link
Contributor

ZanSara commented Mar 11, 2022 •
edited
Loading

Problem
During the YAML validation PR, I realized that the distinction between BasePipeline and Pipeline is rather blurry and probably unnecessary. See this comments for more context: #2226 (comment)

Solution
We should probably have a single, non-abstract Pipeline base class which can be used as-is or subclassed by others, like RayPipeline.
@ZanSara ZanSara changed the title I agree, that the purpose of BasePipeline vanishes with deleting the "generic" load_from_config that would delegate between it's subclasses Pipeline and RayPipeline depending on the config's pipeline type. All the deepset_cloud methods could as well be part of Pipeline. So let's leave it like that and think about redesigning BasePipeline/Pipeline or even adding DeepsetCloudPipeline in a separate issue/PR. Re-evaluate BasePipeline Mar 11, 2022
@ZanSara ZanSara added topic:pipeline type:refactor Not necessarily visible to the users labels Mar 11, 2022
@ZanSara ZanSara self-assigned this Mar 21, 2022
@ZanSara ZanSara mentioned this issue Apr 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZanSara ZanSara

Labels
topic:pipeline type:refactor Not necessarily visible to the users
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate YAML files without loading the nodes deepset-ai/haystack
1 participant
@ZanSara