Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PreProcessor support Document objects #2292

Closed
ZanSara opened this issue Mar 9, 2022 · 1 comment
Closed

Make PreProcessor support Document objects #2292

ZanSara opened this issue Mar 9, 2022 · 1 comment
Assignees
Labels
topic:preprocessing type:bug Something isn't working type:feature New feature or request

Comments

@ZanSara
Copy link
Contributor

ZanSara commented Mar 9, 2022

Problem
Right now PreProcessor (as many other "indexing" nodes) do not really support Document objects, I don't see a reason why that should be the case other than legacy. In addition, the current error message is highly misleading because, given a Document, PreProcessor will complain that the given value is "neither a list nor a Document", when it should say "neither a list nor a dictionary".

Solution
I propose to update PreProcessor to be able to deal with proper Document objects and review other nodes with document: Dict or documents: List[Dict] in their signatures.

@ZanSara ZanSara added type:bug Something isn't working type:feature New feature or request topic:preprocessing labels Mar 9, 2022
@ZanSara ZanSara self-assigned this Mar 9, 2022
@ZanSara
Copy link
Contributor Author

ZanSara commented Apr 11, 2022

Should be fixed by #2342, closing

@ZanSara ZanSara closed this as completed Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:preprocessing type:bug Something isn't working type:feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant