Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend filter functionality for ElasticsearchDocumentStore #2029

Closed
bogdankostic opened this issue Jan 19, 2022 · 2 comments · Fixed by #2108
Closed

Extend filter functionality for ElasticsearchDocumentStore #2029

bogdankostic opened this issue Jan 19, 2022 · 2 comments · Fixed by #2108
Assignees
@bogdankostic
Labels
topic:document_store topic:elasticsearch topic:metadata type:feature New feature or request

Comments

@bogdankostic
Copy link
Contributor

We want to allow users to filter their documents inside an ElasticsearchDocumentStore based on a combination of logical and comparison operators. Filters can be set in Elasticsearch within a boolean query. It seems that the must occurrence type corresponds to the logical AND operator, must_not to the logical NOT operator and should to the logical OR operator (with minimum_should_match set to 1). Greater or less than operations have to be defined inside the range parameter.
@SjSnowball
Copy link
Contributor

@bogdankostic It will be great if we have the above feature included. It adds lots of flexibility and avoids the postprocessing steps. I would love to work on this issue. Please let me know.

@bogdankostic bogdankostic self-assigned this Feb 2, 2022
@bogdankostic bogdankostic mentioned this issue Feb 2, 2022
Merged
@bogdankostic
Copy link
Contributor Author

Hi @SjSnowball! Thanks for your interest in this issue. I already created a PR (#2108) that extends the metadata filtering support in the ElasticsearchDocumentStore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bogdankostic bogdankostic

Labels
topic:document_store topic:elasticsearch topic:metadata type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extend metadata filtering support in ElasticsearchDocumentStore deepset-ai/haystack
2 participants
@bogdankostic @SjSnowball