Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback: haystack installation in tutorial #189

Closed
PhilipMay opened this issue Jul 3, 2020 · 1 comment
Closed

Feedback: haystack installation in tutorial #189

PhilipMay opened this issue Jul 3, 2020 · 1 comment

Comments

@PhilipMay
Copy link
Contributor

PhilipMay commented Jul 3, 2020

In Tutorial3_Basic_QA_Pipeline_without_Elasticsearch you say to install haystack with:
! pip install git+git://github.com/deepset-ai/haystack.git@ef9e4f4467a2e265bad72b048a1a3186e40969b1

I suggest to change that to:
! pip install git+https://github.com/deepset-ai/haystack.git@ef9e4f4467a2e265bad72b048a1a3186e40969b1

On some environments (like our corporate ML server) only http and https is working to connect to the outside...

Even better would be to say:
! pip install git+https://github.com/deepset-ai/haystack.git
Without the suffix. With adding a suffix you basicaly say "hey our master branch is not always clean" - which is bad.

PS: Please also check the other tutorial versions...

@tholor
Copy link
Member

tholor commented Jul 7, 2020

Thanks for the feedback.
We used the install from a specific commit in the early phase of the project to speed up development a bit while ensuring functional tutorials.
I agree that this is not nice and can create confusion.

Changed it in #200 to install from latest master via https.
In future, we might switch this to the latest PyPi release and get completely rid of the "git installation".

@tholor tholor closed this as completed Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants