You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It differs from the 2 versions in the tutorials directory.
This line is different for example: write_documents_to_db(document_store=document_store, document_dir=doc_dir, clean_func=clean_wiki_text, only_empty_db=True)
My suggestion: Only add a notebook with a Colab button. No .py and no Colab.
PS: Please also check the other tutorial versions...
The text was updated successfully, but these errors were encountered:
PhilipMay
changed the title
Different Colab example for Tutorial3_Basic_QA_Pipeline_without_Elasticsearch
Feedback: Different Colab example for Tutorial3_Basic_QA_Pipeline_without_Elasticsearch
Jul 3, 2020
Thanks for spotting! The link in the readme was incorrectly pointing to an old branch instead of master.
Fixed it in #200.
We personally work more with IDEs than notebooks and therefore like the .py scripts a lot for debugging or helping some other users. Therefore we'll keep them.
Regarding the Colab button. If I am not missing anything the functionality is the same as with our link: one jupyter notebook that gets opened via Colab. So also with the current state there's no "jupyer" vs "colab" version. It's always the same notebook.
Hi,
@Timoeller asked me for feedback to Haystack...
Tutorial3_Basic_QA_Pipeline_without_Elasticsearch has a different colab version which is confusing.
This is linked from README:
https://colab.research.google.com/github/deepset-ai/haystack/blob/update-tutorials/tutorials/Tutorial3_Basic_QA_Pipeline_without_Elasticsearch.ipynb
It differs from the 2 versions in the tutorials directory.
This line is different for example:
write_documents_to_db(document_store=document_store, document_dir=doc_dir, clean_func=clean_wiki_text, only_empty_db=True)
My suggestion: Only add a notebook with a Colab button. No
.py
and no Colab.PS: Please also check the other tutorial versions...
The text was updated successfully, but these errors were encountered: