Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change return type of File Converters to List[Document] #1859

Closed
bogdankostic opened this issue Dec 8, 2021 · 1 comment · Fixed by #2342
Closed

Change return type of File Converters to List[Document] #1859

bogdankostic opened this issue Dec 8, 2021 · 1 comment · Fixed by #2342
Assignees

Comments

@bogdankostic
Copy link
Contributor

Currently, the file converters are returning List[Dict]. We should make use of our Document primitive here and return List[Document] instead.

@tholor
Copy link
Member

tholor commented Dec 16, 2021

Same refactoring is needed for the other nodes in our indexing pipeline (e.g. Preprocessor).

When working on this, we should take into account that we create the document's id at the moment when we instantiate the Document. If this now happens within different nodes, we probably need to add a param there to control the way how these ids are created (default: hash of content). For example, in DC we want to create the ID based on content + a pipeline_id. This can be done via id_hash_keys parameter in Document.init().

Ping @ArzelaAscoIi when kicking the work off here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants