model_devi_clean_traj support int type #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## devel #583 +/- ##
==========================================
- Coverage 33.13% 33.12% -0.01%
==========================================
Files 86 86
Lines 14799 14809 +10
==========================================
+ Hits 4903 4906 +3
- Misses 9896 9903 +7
Continue to review full report at Codecov.
|
AnguseZhang
requested changes
Nov 2, 2021
|
Thank you for the review. I have update description of model_devi_clean_traj in the README. |
AnguseZhang
approved these changes
Nov 5, 2021
Cloudac7
pushed a commit
to Cloudac7/dpgen
that referenced
this pull request
Dec 1, 2021
* model_devi_clean_traj support buffer * fix clean index * update readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if model_devi_clean_traj is integer, then the most recent n iterations will be retained, others will be removed.