Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add and run pre-commit to format codes #1124

Merged
merged 7 commits into from
Jan 27, 2023
Merged

add and run pre-commit to format codes #1124

merged 7 commits into from
Jan 27, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jan 25, 2023 •
edited
Loading

  • add pre-commit config, including black and common fixes.
  • run pre-commit.
  • manually fix a YAML file.
  • skip check json and broken symlinks.

@njzjz njzjz changed the title devel add and run pre-commit checks Jan 25, 2023
@njzjz njzjz marked this pull request as draft January 25, 2023 19:40
@njzjz njzjz marked this pull request as ready for review January 25, 2023 19:54
@njzjz njzjz changed the title add and run pre-commit checks add and run pre-commit to format codes Jan 26, 2023
wanghan-iapcm
wanghan-iapcm approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add Yuzhi as reviewer

AnguseZhang
AnguseZhang approved these changes Jan 27, 2023
View reviewed changes
.pre-commit-config.yaml Show resolved Hide resolved
@wanghan-iapcm wanghan-iapcm merged commit 57a8c16 into deepmodeling:devel Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghan-iapcm wanghan-iapcm wanghan-iapcm approved these changes

@AnguseZhang AnguseZhang AnguseZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njzjz @AnguseZhang @wanghan-iapcm