Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(submission): add async submission and unittest #348

Merged
merged 3 commits into from
Jun 30, 2023
Merged

feat(submission): add async submission and unittest #348

merged 3 commits into from
Jun 30, 2023

Conversation

ixsluo
Copy link
Contributor

@ixsluo ixsluo commented Jun 29, 2023

Feat #347

  1. add check_interval
  2. add async_run_submission method
  3. add unittest of the async func

Known bugs:
Async submission may fail on pbs/slurm queue system, but success on lazylocal test.

@codecov
Copy link

codecov bot commented Jun 29, 2023 •
edited
Loading

Codecov Report

Patch coverage: 90.90% and project coverage change: +0.04 🎉

Comparison is base (3528930) 62.60% compared to head (1c85c02) 62.65%.

❗ Current head 1c85c02 differs from pull request most recent head 787289c. Consider uploading reports for the commit 787289c to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #348      +/-   ##
==========================================
+ Coverage   62.60%   62.65%   +0.04%     
==========================================
  Files          27       27              
  Lines        2939     2948       +9     
==========================================
+ Hits         1840     1847       +7     
- Misses       1099     1101       +2
Impacted Files Coverage Δ
dpdispatcher/submission.py 91.00% <90.90%> (-0.05%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@njzjz njzjz linked an issue Jun 29, 2023 that may be closed by this pull request
add asynchronous execution on run_submission #347
Open
njzjz
njzjz requested changes Jun 29, 2023
View reviewed changes
tests/test_run_submission.py
)
)

def test_async_run_submission(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please skip the tests in slurm or PBS if they don't work to ensure the CI passes. Also, could you add some comments on this situation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I will skip the test.
It is weird that, on action triggered by my push and PR, the three slurm test may success. I don't know why and I think it is in the clean behavior.

@ixsluo ixsluo mentioned this pull request Jun 30, 2023
Open
@njzjz njzjz merged commit abfe441 into deepmodeling:master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njzjz njzjz njzjz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add asynchronous execution on run_submission
2 participants
@ixsluo @njzjz