style: enable B904

[njzjz]

As planned in #3933 (comment)

Summary by CodeRabbit

• Bug Fixes

  • Improved exception handling across multiple modules to provide more context in error messages.

• Chores

  • Added rule B904 for raise-without-from-inside-except to pyproject.toml.

These changes enhance debugging by offering clearer error messages and context, thus improving the overall user experience when dealing with exceptions.

[coderabbitai]

Walkthrough

Walkthrough

The latest changes involve improving exception handling across various modules. The main updates include appending the original exceptions as context using from e and similar constructs. This ensures better traceability and clarity when exceptions are raised, making debugging more straightforward. Additionally, the pyproject.toml has been updated to enforce the new exception handling rule.

Changes

Files/Modules	Change Summary
backend/find_tensorflow.py	Enhanced RuntimeError handling by adding from None.
deepmd/dpmodel/descriptor/descriptor.py, deepmd/pt/model/descriptor/descriptor.py	Improved exception handling in DescriptorBlock class using from e.
deepmd/entrypoints/neighbor_stat.py	Modified KeyError handling to include the original exception (e).
deepmd/utils/data_system.py	Added context to ValueError handling using as e.
pyproject.toml	Added B904 rule for raise-without-from-inside-except.
source/tests/common/test_argument_parser.py	Enhanced SystemExit handling by including original exception using from e.
source/tests/tf/test_parallel_training.py	Improved ImportError handling to include context using from e.

Sequence Diagram(s)

The changes are primarily focused on exception handling improvements, which do not significantly affect the control flow or introduce new features. Therefore, generating sequence diagrams does not apply in this context.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.83%. Comparing base (7ce7f38) to head (ccdf86d).
Report is 109 commits behind head on devel.

Files with missing lines	Patch %	Lines
deepmd/dpmodel/descriptor/descriptor.py	0.00%	2 Missing ⚠️
deepmd/entrypoints/neighbor_stat.py	0.00%	2 Missing ⚠️
deepmd/pt/model/descriptor/descriptor.py	0.00%	2 Missing ⚠️
deepmd/utils/data_system.py	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            devel    #3956      +/-   ##
==========================================
- Coverage   82.83%   82.83%   -0.01%     
==========================================
  Files         520      520              
  Lines       50832    50832              
  Branches     3011     3015       +4     
==========================================
- Hits        42109    42106       -3     
  Misses       7790     7790              
- Partials      933      936       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[njzjz]

FAILED source/tests/universal/dpmodel/model/test_model.py::TestSpinEnergyModelDP_(<function DescriptorParamDPA2_strip_True_False_False_True_True_True_True_True_True_False_True_res_avg_norm_True_True_1e-05_True_[]_float64_True_False at 0x7f6cd274eb60>, <class 'deepmd.dpmodel.descriptor.dpa2.DescrptDPA2'>)_(<function FittingParamEnergy_[]_float64_0 at 0x7f6cd27d54e0>, <class 'deepmd.dpmodel.fitting.ener_fitting.EnergyFittingNet'>)::test_rot - AssertionError: 
Not equal to tolerance rtol=1e-07, atol=0
compare energy before and after transform
Mismatched elements: 1 / 5 (20%)
Max absolute difference: 4.76259832e-09
Max relative difference: 5.47819454e-07
 x: array([[[8.116176e-01],
        [1.014942e+01],
        [2.863786e+00],...
 y: array([[[8.116176e-01],
        [1.014942e+01],
        [2.863786e+00],...
= 1 failed, 5349 passed, 2253 skipped, 38011 deselected, 34 warnings in 1208.00s (0:20:07) =

[iProzd]

FAILED source/tests/universal/dpmodel/model/test_model.py::TestSpinEnergyModelDP_(<function DescriptorParamDPA2_strip_True_False_False_True_True_True_True_True_True_False_True_res_avg_norm_True_True_1e-05_True_[]_float64_True_False at 0x7f6cd274eb60>, <class 'deepmd.dpmodel.descriptor.dpa2.DescrptDPA2'>)_(<function FittingParamEnergy_[]_float64_0 at 0x7f6cd27d54e0>, <class 'deepmd.dpmodel.fitting.ener_fitting.EnergyFittingNet'>)::test_rot - AssertionError: 
Not equal to tolerance rtol=1e-07, atol=0
compare energy before and after transform
Mismatched elements: 1 / 5 (20%)
Max absolute difference: 4.76259832e-09
Max relative difference: 5.47819454e-07
 x: array([[[8.116176e-01],
        [1.014942e+01],
        [2.863786e+00],...
 y: array([[[8.116176e-01],
        [1.014942e+01],
        [2.863786e+00],...
= 1 failed, 5349 passed, 2253 skipped, 38011 deselected, 34 warnings in 1208.00s (0:20:07) =

Fix in #3957