Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: pt: remove data stat from model init #3245

Merged
merged 9 commits into from
Feb 10, 2024

allow kwargs for child method

dd1a7a8
Select commit
Loading
Failed to load commit list.
Merged

breaking: pt: remove data stat from model init #3245

allow kwargs for child method
dd1a7a8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 9, 2024 in 0s

75.30% (+0.10%) compared to c235099

View this Pull Request on Codecov

75.30% (+0.10%) compared to c235099

Details

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (c235099) 75.19% compared to head (dd1a7a8) 75.30%.

Files Patch % Lines
deepmd/pt/model/descriptor/descriptor.py 79.16% 10 Missing ⚠️
deepmd/pt/model/descriptor/hybrid.py 9.09% 10 Missing ⚠️
deepmd/pt/model/task/ener.py 85.18% 4 Missing ⚠️
deepmd/pt/model/task/fitting.py 91.42% 3 Missing ⚠️
deepmd/dpmodel/descriptor/make_base_descriptor.py 33.33% 2 Missing ⚠️
deepmd/dpmodel/fitting/invar_fitting.py 50.00% 2 Missing ⚠️
deepmd/dpmodel/fitting/make_base_fitting.py 50.00% 2 Missing ⚠️
deepmd/pt/entrypoints/main.py 66.66% 2 Missing ⚠️
deepmd/pt/model/model/dp_atomic_model.py 94.73% 1 Missing ⚠️
deepmd/pt/model/model/model.py 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #3245      +/-   ##
==========================================
+ Coverage   75.19%   75.30%   +0.10%     
==========================================
  Files         372      372              
  Lines       33136    33220      +84     
  Branches     1608     1608              
==========================================
+ Hits        24916    25015      +99     
+ Misses       7347     7332      -15     
  Partials      873      873

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov