Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] pt: fix get_sel, get_type, etc. in linear_atomic_models #3502

Closed
njzjz opened this issue Mar 19, 2024 · 1 comment · Fixed by #3759
Closed

[Feature Request] pt: fix get_sel, get_type, etc. in linear_atomic_models #3502

njzjz opened this issue Mar 19, 2024 · 1 comment · Fixed by #3759
Assignees
Milestone

Comments

@njzjz
Copy link
Member

njzjz commented Mar 19, 2024

No description provided.

@wanghan-iapcm
Copy link
Collaborator

I find the behavior of get_sel, get_type of linear atomic model is the same as that of the hybrid descriptor.

but the linear atomic model assumes that all the sub-models are of mixed type. This restriction should be checked at constructor and an error is expected to raise when the restriction is not fulfilled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants