Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD: Link ZLIB to CNPY #5002

Closed
16 tasks
jieli-matrix opened this issue Aug 26, 2024 · 1 comment · Fixed by #5003
Closed
16 tasks

BUILD: Link ZLIB to CNPY #5002

jieli-matrix opened this issue Aug 26, 2024 · 1 comment · Fixed by #5003
Assignees
Labels
Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS

Comments

@jieli-matrix
Copy link
Collaborator

Describe the bug

Currently, ZLIB is not linked to CNPY, which leads to a build error when compiling ABACUS with the DENABLE_CNPY=1 option. The following error is encountered:

/usr/bin/ld: source/module_esolver/CMakeFiles/esolver.dir/io_npz.cpp.o: undefined reference to symbol 'crc32'
/usr/bin/ld: /lib/x86_64-linux-gnu/libz.so.1: error adding symbols: DSO missing from command line
icpx: error: linker command failed with exit code 1 (use -v to see invocation)

Expected behavior

Modify the CMakeLists.txt to correctly link ZLIB with CNPY during the build process. This should resolve the undefined reference to symbol crc32 error and ensure that the build completes successfully.

To Reproduce

No response

Environment

No response

Additional Context

No response

Task list for Issue attackers (only for developers)

  • Verify the issue is not a duplicate.
  • Describe the bug.
  • Steps to reproduce.
  • Expected behavior.
  • Error message.
  • Environment details.
  • Additional context.
  • Assign a priority level (low, medium, high, urgent).
  • Assign the issue to a team member.
  • Label the issue with relevant tags.
  • Identify possible related issues.
  • Create a unit test or automated test to reproduce the bug (if applicable).
  • Fix the bug.
  • Test the fix.
  • Update documentation (if necessary).
  • Close the issue and inform the reporter (if applicable).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@jieli-matrix and others