Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-Controlled DOS and PDOS Outputs in ABACUS's out_dos #4660

Closed
14 tasks
Chentao168 opened this issue Jul 12, 2024 · 1 comment
Closed
14 tasks

User-Controlled DOS and PDOS Outputs in ABACUS's out_dos #4660

Chentao168 opened this issue Jul 12, 2024 · 1 comment
Assignees
Labels
Input&Output Suitable for coders without knowing too many DFT details

Comments

@Chentao168
Copy link
Collaborator

Background

Currently, ABACUS's out_dos outputs both DOS (Density of States) and PDOS (Projected Density of States) simultaneously in the LCAO (Linear Combination of Atomic Orbitals) method, which results in large PDOS files. It is necessary to give users the option to choose whether to output PDOS or not.

Describe the solution you'd like

It is suggested that setting out_dos to 1 should output only the DOS, while setting it to 2 should output both DOS and PDOS concurrently.

Task list only for developers

  • Notice possible changes of behavior
  • Explain the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi

Notice Possible Changes of Behavior (Reminder only for developers)

No response

Notice any changes of core modules (Reminder only for developers)

No response

Notice Possible Changes of Core Modules (Reminder only for developers)

No response

Additional Context

No response

Task list for Issue attackers (only for developers)

  • Review and understand the proposed feature and its importance.
  • Research on the existing solutions and relevant research articles/resources.
  • Discuss with the team to evaluate the feasibility of implementing the feature.
  • Create a design document outlining the proposed solution and implementation details.
  • Get feedback from the team on the design document.
  • Develop the feature following the agreed design.
  • Write unit tests and integration tests for the feature.
  • Update the documentation to include the new feature.
  • Perform code review and address any issues.
  • Merge the feature into the main branch.
  • Monitor for any issues or bugs reported by users after the feature is released.
  • Address any issues or bugs reported by users and continuously improve the feature.
@Chentao168 Chentao168 self-assigned this Jul 12, 2024
@mohanchen mohanchen added the Input&Output Suitable for coders without knowing too many DFT details label Jul 12, 2024
@Chentao168
Copy link
Collaborator Author

Fixed in #4782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Input&Output Suitable for coders without knowing too many DFT details
Projects
None yet
Development

No branches or pull requests

2 participants