Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add global shortcut to export logs #2336

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ericlln
Copy link

@ericlln ericlln commented Jan 9, 2025

  • Added Ctrl+Alt+Shift+L/Cmd-Option-Shift-L as a global shortcut for exporting support logs
  • When pressed in code-studio, it will download logs with the same contents as logs produced by pressing the 'Export Logs' button in the settings menu
  • When pressed in other contexts: when not logged in, on a reconnect error, or in embed-widgets, the logs are exported without the plugin and server info
  • Tested by E2E tests that navigate to the various contexts, presses the shortcut, and checks if a file was downloaded. Can further inspect the file downloaded in the tests but unsure if that's necessary

Closes #1963

@ericlln ericlln requested a review from mofojed January 9, 2025 15:03
@ericlln ericlln self-assigned this Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ericlln
Copy link
Author

ericlln commented Jan 9, 2025

I have read the CLA Document and I hereby sign the CLA

deephaven-internal added a commit to deephaven/cla that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to export support logs before logging in or after there's a connection error
1 participant