Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: Revert "fix: Console history did not stick to bottom on visibility changes (#2320)" #2323

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Dec 30, 2024

This reverts commit 648e8c0.

@mofojed mofojed requested a review from dgodinez-dh December 30, 2024 17:22
@mofojed mofojed self-assigned this Dec 30, 2024
@mofojed mofojed enabled auto-merge (squash) December 30, 2024 17:25
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.71%. Comparing base (648e8c0) to head (ceaeabc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/console/src/Console.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2323    +/-   ##
========================================
  Coverage   46.70%   46.71%            
========================================
  Files         704      704            
  Lines       39026    39013    -13     
  Branches     9935     9747   -188     
========================================
- Hits        18229    18224     -5     
+ Misses      20786    20778     -8     
  Partials       11       11            
Flag Coverage Δ
unit 46.71% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed merged commit 9d6719a into deephaven:main Dec 30, 2024
11 checks passed
@mofojed mofojed deleted the revert-console-scroll-fix branch December 30, 2024 17:36
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants