Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Unavailable Dates for Date Picker #698

Open
Tracked by #367
dgodinez-dh opened this issue Aug 5, 2024 · 0 comments
Open
Tracked by #367

Implement Unavailable Dates for Date Picker #698

dgodinez-dh opened this issue Aug 5, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@dgodinez-dh
Copy link
Contributor

For #367, the initial implementation has the unavailable_dates prop commented out.

This list of dates was sent over to the Javascript which create an isDateUnavailable function by checking if the date provided by the Spectrum API was included in the Set of dates proved by Python. The problem is that these dates have granularity down to the millisecond which means that any small change in the time will cause the comparison to fail. The Javascript needs to be smarter. It should drop any time information and just do comparison on the CalendarDate.

We might need to rethink the Python API. Is there any point saying 2024-01-01T12:10:30 is unavailable vs just 2024-01-01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants