Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficient registration of multiple io.deephaven.plugin.Plugin #3007

Open
devinrsmith opened this issue Oct 20, 2022 · 1 comment
Open

Efficient registration of multiple io.deephaven.plugin.Plugin #3007

devinrsmith opened this issue Oct 20, 2022 · 1 comment
Assignees
Labels
feature request New feature or request plug-ins
Milestone

Comments

@devinrsmith
Copy link
Member

Spawned from #2908

io.deephaven.server.jetty.jsplugin.JsPluginsZipFilesystem currently writes a manifest N + 1 times, where N is the number of JsPlugin that have been registered. This results in re-writing the whole .zip file N + 1 times. It should be possible to be more efficient about this - at least in the case of startup where we do mass registration.

More generally, it may make sense to plumb through the ability to register more than one plugin at once, ie io.deephaven.plugin.Registration.Callback#registerAll.

We do need to be careful about liveness concerns - specifically regarding io.deephaven.plugin.type.JsPlugin#copyTo, which python is responsible for managing the path w/ a @contextmanager, see py/server/deephaven/server/plugin/register.py

@devinrsmith devinrsmith added feature request New feature or request plug-ins labels Oct 20, 2022
@devinrsmith devinrsmith added this to the Backlog milestone Oct 20, 2022
@devinrsmith devinrsmith self-assigned this Oct 20, 2022
@devinrsmith
Copy link
Member Author

Any implementation of this must not block progress for #1809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request plug-ins
Projects
None yet
Development

No branches or pull requests

1 participant