Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OS Builds github workflow #138

Closed
FreePhoenix888 opened this issue Oct 2, 2023 · 10 comments
Closed

Fix OS Builds github workflow #138

FreePhoenix888 opened this issue Oct 2, 2023 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@FreePhoenix888
Copy link
Member

FreePhoenix888 commented Oct 2, 2023

Description

OS Builds github workflow falls with error

Questions
Why is `build-electron` script not used before `cd electron` to generate fresh electron folder?

build-electron script:

"build-electron": "npm run build && npm run export && npx rimraf electron/app && npx cap copy electron",

Step with cd electron:

- name: Install electron dependencies
run: cd electron && npm ci

Why `--force` option is used for `npm ci`?

- name: Install dc dependencies
run: npm ci --force

@FreePhoenix888
Copy link
Member Author

FreePhoenix888 commented Dec 14, 2023

Commits I have done:

New error: https://github.com/deep-foundation/deep-memo-app/actions/runs/7206827139/job/19632419281

We have electron-unhandled dependency in both package.json and package-lock.json:

"electron-unhandled": "~4.0.1",

"electron-unhandled": {
"version": "4.0.1",
"resolved": "https://registry.npmjs.org/electron-unhandled/-/electron-unhandled-4.0.1.tgz",
"integrity": "sha512-6BsLnBg+i96eUnbaIFZyYdyfNX3f80/Nlfqy34YEMxXT9JP3ddNsNnUeiOF8ezN4+et4t4D37gjghKTP0V3jyw==",
"requires": {
"clean-stack": "^2.1.0",
"electron-is-dev": "^2.0.0",
"ensure-error": "^2.0.0",
"lodash.debounce": "^4.0.8",
"serialize-error": "^8.1.0"
}
},

But npm ci is executed afteer build-electron. If we move it before build-electron we will get the previous error that tells that package.json and package-lock.json are not syncronized.

Question: What should syncronize package.json and package-lock.json by calling npm install? Developer manually? build-electron script? Should we use npm install instead of npm clean-install in github actions?

@FreePhoenix888
Copy link
Member Author

Error: https://github.com/deep-foundation/deep-memo-app/actions/runs/7219140330/job/19669641858
Why do we need to pull latest deeplinks from repo?

- name: pull dl
run: cd node_modules/@deep-foundation && rm -rf deeplinks && git clone https://github.com/deep-foundation/deeplinks.git && cd deeplinks && npm ci && npm run package:build && rm -rf node_modules && rm -rf package-lock.json && cd ../../.. && rm -rf electron/node_modules/@deep-foundation/deeplinks

@FreePhoenix888
Copy link
Member Author

https://github.com/deep-foundation/deep-memo-app/actions/runs/7220293841/job/19672925219

@FreePhoenix888
Copy link
Member Author

I have fixed linux build: https://github.com/deep-foundation/deep-memo-app/actions/runs/7220828439/job/19674532971

@ivansglazunov
Copy link
Member

Description

OS Builds github workflow falls with error

Questions
Why is `build-electron` script not used before `cd electron` to generate fresh electron folder?

build-electron script:

"build-electron": "npm run build && npm run export && npx rimraf electron/app && npx cap copy electron",

Step with cd electron:

- name: Install electron dependencies
run: cd electron && npm ci

Why `--force` option is used for `npm ci`?

- name: Install dc dependencies
run: npm ci --force

Force need for ignore not critical versions conflict

@FreePhoenix888
Copy link
Member Author

@FreePhoenix888
Copy link
Member Author

@FreePhoenix888
Copy link
Member Author

@FreePhoenix888
Copy link
Member Author

There are some hardcoded versions in github workflow, I need to fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants