-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OS Builds github workflow #138
Comments
Commits I have done: New error: https://github.com/deep-foundation/deep-memo-app/actions/runs/7206827139/job/19632419281 We have electron-unhandled dependency in both deep-memo-app/electron/package.json Line 33 in 52e31e6
deep-memo-app/electron/package-lock.json Lines 1834 to 1845 in 52e31e6
But npm ci is executed afteer build-electron . If we move it before build-electron we will get the previous error that tells that package.json and package-lock.json are not syncronized.
Question: What should syncronize |
Error: https://github.com/deep-foundation/deep-memo-app/actions/runs/7219140330/job/19669641858 deep-memo-app/.github/workflows/os-builds.yaml Lines 57 to 58 in d87b125
|
I have fixed linux build: https://github.com/deep-foundation/deep-memo-app/actions/runs/7220828439/job/19674532971 |
Force need for ignore not critical versions conflict |
I have fixed mac build: https://github.com/deep-foundation/deep-memo-app/actions/runs/7230652016/job/19702947915 |
I have fixed windows build: https://github.com/deep-foundation/deep-memo-app/actions/runs/7230860631/job/19703403317 |
The first release is executed successfully: https://github.com/deep-foundation/deep-memo-app/actions/runs/7230898644 |
There are some hardcoded versions in github workflow, I need to fix that |
Description
OS Builds github workflow falls with error
Questions
Why is `build-electron` script not used before `cd electron` to generate fresh electron folder?
build-electron
script:deep-memo-app/package.json
Line 25 in 4552d5a
Step with
cd electron
:deep-memo-app/.github/workflows/os-builds.yaml
Lines 55 to 56 in f422833
Why `--force` option is used for `npm ci`?
deep-memo-app/.github/workflows/os-builds.yaml
Lines 53 to 54 in f422833
The text was updated successfully, but these errors were encountered: