Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding G1 for the bn256 package #475

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Embedding G1 for the bn256 package #475

merged 1 commit into from
Oct 28, 2022

Conversation

ineiti
Copy link
Member

@ineiti ineiti commented Sep 23, 2022

Creating a PR for #383 so that all tests can pass.

@taybart - if you want changes, create a PR against this PR, and I'll merge it.

Sorry for the difficulties with sonarcloud.

Co-authored-by: taybart
@CLAassistant
Copy link

CLAassistant commented Sep 23, 2022

CLA assistant check
All committers have signed the CLA.

@ineiti ineiti self-assigned this Sep 23, 2022
@ineiti ineiti mentioned this pull request Sep 23, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

95.0% 95.0% Coverage
0.0% 0.0% Duplication

@ineiti ineiti requested a review from pierluca September 23, 2022 12:03
@taybart
Copy link

taybart commented Oct 28, 2022

I would love git blame credit but if it gets merged I would be super happy. Thanks!

@nkcr nkcr merged commit 4ecf537 into master Oct 28, 2022
@nkcr nkcr deleted the taybart_383 branch October 28, 2022 08:25
@ineiti
Copy link
Member Author

ineiti commented Oct 28, 2022

I would love git blame credit but if it gets merged I would be super happy. Thanks!

I co-authored you in the commit - but unfortunately that doesn't give you git-blame-credits, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants