Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinoWS module #289

Closed
wants to merge 7 commits into from
Closed

MinoWS module #289

wants to merge 7 commits into from

Conversation

ineiti
Copy link
Member

@ineiti ineiti commented Sep 24, 2024

Adding minows module to replace the minogrpc module.

One of the tests fails, but runs correctly when being run apart in the 1-out-of-3 test loop: c4dt#24

Waiting for acceptance of this one, before changing this one back to non-draft.

ineiti and others added 5 commits July 5, 2024 10:07
Co-authored-by: Zach Xion [email protected]

This commit implements a new Mino handler using libp2p with websockets.
Contrary to MinoGRPC it doesn't use any locks and uses a 1-level tree to handle messages.
It is at least as performant as the MinoGRPC implementation, and works with d-voting.
- Adding new version of libp2p
- Re-enabling failing test and remove goverall
- Use peer.ID.Validate
- Don't export Packet and Forward
- Merging participant and orchestrator
@pierluca pierluca requested review from jbsv and pierluca September 24, 2024 12:45
@ineiti ineiti marked this pull request as draft September 24, 2024 12:46
- There was a race-condition in the echoHandler which made it fail on
fast machines.
- Changed the tests to wait for the accurate number of messages, instead
of waiting for 2 seconds.
- Also fixed an incompatibility in the Makefile wrt the github runners.
- Added a test to the fuzzy tests in the Makefile
Fixing race condition and adding fuzzy test
@ineiti ineiti marked this pull request as ready for review October 10, 2024 07:20
@ineiti ineiti closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants