Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden service support for server #1569

Closed
martonp opened this issue Apr 7, 2022 · 3 comments
Closed

Hidden service support for server #1569

martonp opened this issue Apr 7, 2022 · 3 comments
Assignees
Milestone

Comments

@martonp
Copy link
Collaborator

martonp commented Apr 7, 2022

Support running the server as a hidden service. Also, the client must be updated to allow connecting to hidden service servers.

@martonp
Copy link
Collaborator Author

martonp commented Apr 7, 2022

I'll work on this.

@chappjc
Copy link
Member

chappjc commented Apr 7, 2022

Alright! In ways this is already doable as-is, so it's mostly about what features and capabilities we'd like to add to smooth out the pain points.

For server, it should work presently with the hidden service pointing at the existing listener. The headaches there are: (a) seemingly needless TLS over tor, and (b) server needs to generate a new TLS certificate that includes the onion address in the alt dns names, breaking clients using the older one. So my thoughts about that are either a second listener for the hidden service connections, and/or updating the tls.Config with multiple certificates in the slice so you effectively create "virtual servers":

tlsConfig := tls.Config{
Certificates: []tls.Certificate{keypair},

On a related note, I had notes about an extracerts option for dcrdex even in the context of regular internet, no hidden service, because it may be desirable to have different domains / ip addresses on different certificates (again, virtual servers).

For client, if torproxy= is enabled things would probably work out, but as with other apps, there can be a dedicated onion= flag so that regular internet connections don't use tor, only onion addresses.

@chappjc
Copy link
Member

chappjc commented Apr 21, 2022

Resolved by #1571

@chappjc chappjc closed this as completed Apr 21, 2022
@chappjc chappjc added this to the 0.4.3 milestone Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants