Skip to content
This repository has been archived by the owner on May 13, 2021. It is now read-only.

Add support for line segments #11

Open
MartinSStewart opened this issue Jan 19, 2020 · 2 comments
Open

Add support for line segments #11

MartinSStewart opened this issue Jan 19, 2020 · 2 comments

Comments

@MartinSStewart
Copy link

MartinSStewart commented Jan 19, 2020

This package fails to parse obj files that contain line segments (i.e. l 346 357). I'm guessing this is known since the limitations section in the readme says No free-form curves. If there are plans to extend this package then this feature would be useful for me.

Edit: I've implemented a version of it here that works well enough for my purposes but isn't good enough to release as a package https://github.com/MartinSStewart/elm-obj-loader. Still, it might be of use if you decide to work on this feature.

@declension
Copy link
Owner

Sorry, must have missed this somehow.

I've not really ended up using this, having ported it from @Zinggi's original. That said, if you'd like to make a PR from your fork that would be great :)

@MartinSStewart
Copy link
Author

Hey declension! I've added line segment support but it's buggy and unfit for general use. If that changes then I'll make PR though.

@declension declension changed the title Add support for line segements Add support for line segments Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants