New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize #1

Open

deciduously opened this issue May 23, 2018 · 2 comments

Assignees

Owner

deciduously commented May 23, 2018

There's a lot of slow crap going on here.

Multipliers should look up everything first, and then run the command
Don't load the item table again each Lookup command - just once on invoke

deciduously self-assigned this

Owner Author

deciduously commented Jul 3, 2018

Some of those Strings can and should be Cow<'a, str> . Let's learn all about it

Owner Author

deciduously commented Jul 3, 2018

Also, make more of an effort to generalize. Prefer &[T] over Vec, and generic args constrained to traits instead of concrete types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment