This repository has been archived by the owner on Sep 22, 2020. It is now read-only.
Logangirvin/json serialization #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/security/JweToken.ts
Outdated
| iv = Buffer.from(Base64Url.toBase64(base64EncodedValues[2]), 'base64'); | ||
| ciphertext = Buffer.from(Base64Url.toBase64(base64EncodedValues[3]), 'base64'); | ||
| authTag = Buffer.from(Base64Url.toBase64(base64EncodedValues[4]), 'base64'); | ||
| // 15. Let the Additional Authentication Data (AAD) be ASCII(encodedprotectedHeader) |
There was a problem hiding this comment.
Sanity: missing '3.', and seems odd that '15.' appears here.
…spec, or rather optional to reject.
… to re-encrypt to match the expected output.
codeglobally
approved these changes
Mar 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced support for flattened JSON serialization (#19) on JWS and JWE tokens. More work has to be done for general JSON serialization, however you can encode/sign in flattened format, as well as decrypt and verify from a flattened JSON serialized object as content for the constructor.