Skip to content

Latest commit

 

History

History
21 lines (13 loc) · 1.16 KB

smart_contracts_well_known_issues.md

File metadata and controls

21 lines (13 loc) · 1.16 KB

Smart Contracts Well Knonw Issues

Estate

  • The getFingerprint, and some function to get assets from the users can run out of gas for Estates bigger than 4000 LANDs and users with a lot of assets. They can use other functions to workaround this.

Collections

  • Missing the ERC165 interface registration.
  • Possible front-running of MANA being paid when creating a collection. It does not generate an issue because the MANA goes to the DAO and can be returned.

Rentals

  • The Rentals contract is not compliant with the LANDRegistry tokenMetadata interface (bytes4(keccak256("getMetadata(uint256)"))).
  • The Rentals contract accepts rents for Estates with size 0. It is a NFT rentable contract, no further or specific checks worth it.

Rewards

  • Rewards Smart Contract can't support two signatures for the same item at the same time. Also, the whole tx will fail if one item has been already claimed.

Token Wrapper and Token Manager

  • TokenWrapper and TokenManager Aragon's apps allow anyone with balance to call any not blacklisted smart contract. This makes things like the token escape hatch useless. Anyone can move tokens only if they are sent by mistake.