Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update price issues #663

Merged
merged 6 commits into from
May 25, 2022
Merged

fix: update price issues #663

merged 6 commits into from
May 25, 2022

Conversation

cazala
Copy link
Member

@cazala cazala commented May 25, 2022 •
edited
Loading

This PR fixes a few issues around the update price modal.

  • When updating a listing, the price was localized and used as the value of the input. This can cause parsing issues in certain languages.
  • The expiration date value was not passed to the date field, so the date was not shown.
  • The expiration date value was reduced by 1 day on every update.
  • The submit button was enabled even when the price input was empty.

Fixes #659
Fixed #660
Fixed #661

@fzavalia fzavalia mentioned this pull request May 25, 2022
Closed
fzavalia
fzavalia approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@fzavalia fzavalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✌️✌️✌️✌️✌️

@cazala cazala merged commit a4797cb into master May 25, 2022
@cazala cazala deleted the fix/localization-input branch May 25, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzavalia fzavalia fzavalia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cazala @fzavalia