Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Home Carousel mixing Items and NFTs #2245

Open
1 of 2 tasks
juanmahidalgo opened this issue May 9, 2024 · 0 comments
Open
1 of 2 tasks

[Bug] Home Carousel mixing Items and NFTs #2245

juanmahidalgo opened this issue May 9, 2024 · 0 comments
Assignees

Comments

@juanmahidalgo
Copy link
Contributor

🎉 Description

The Newest Items carousel from the Home Page, sometimes is mixing up Items and NFTs, where it should only show Items.

  • 🐛 This is a bug report.
  • 📈 This is a feature request.

📝 Details

This is due to the selector that puts together the home page carousel content, has a random logic of looking for the id (either item_id or nft_id) in the nftsById or itemsById map, not knowing if the id belongs to an item or nft, so if they collide (in this case they do), it will prioritize it as nft

E.g: The emote here in the first slot of the carousel is an NFT that has the same id of an item (pure coincide)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant