-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Metrics Limits overlay #890
Conversation
efba29c
to
fd0c185
Compare
Deploying with Cloudflare Pages
|
Test this pull request
|
@cyaiox amazing how fast you got this working ❤️ I'm testing in the link to inspector from this PR it seems that when I change the parcel layout in the component of the Scene entity, this UI doesn't react. It always says 2x2 Land, with limits of a 2x2, even if I add or remove parcels from the list. Another thing I'm noticing is that you reach the max textures very fast. Most of the items in the asset packs reuse 3 or 4 common textures. But even if I duplicate a same item many times, each copy adds to the number of textures. I should really only count unique textures, repeated textures should only be counted once |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #890 +/- ##
==========================================
- Coverage 67.42% 67.30% -0.12%
==========================================
Files 519 522 +3
Lines 16064 16093 +29
Branches 2048 2051 +3
==========================================
+ Hits 10831 10832 +1
- Misses 4904 4929 +25
- Partials 329 332 +3 ☔ View full report in Codecov by Sentry. |
{showMetrics && ( | ||
<div ref={overlayRef} className="Overlay"> | ||
<h2 className="Header"> | ||
{scene.layout.base.x}x{scene.layout.base.y} LAND |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the "COLSxROWS" layout only makes sense for the builder, but for scenes with irregular shapes it does not work. For example you could have a scene with the shape of an "S" and that is not translatable to a COLSxROWS format.
Also layout.base
is not being used correctly in this context. The base is the corner of the scene where to originate the x,y,z coordinate system, but is not the number of columns or rows neither.
Also for Worlds the LAND part is not relevant.
So I would say we simply remove the COLSxROWS label from the UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the metrics do refresh when i add new entities (ie drag n drop or duplicate) but it does not when i delete an entity.
This PR adds the scene limits metrics.
https://docs.decentraland.org/creator/development-guide/sdk7/scene-limitations/#scene-limitation-rules